highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-10 22:18:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

miner: Avoid stack-use-after-return in validationinterface

Browse Source 
This is achieved by switching to a shared_ptr.

Also, switch the validationinterfaces in the tests to use shared_ptrs
for the same reason.
This commit is contained in:
MarcoFalke
2020-04-27 10:35:32 -04:00
parent fa5ceb25fc
commit 7777f2a4bb
3 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/validationinterface_tests.cpp
View File

@@ -12,7 +12,6 @@
BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, TestingSetup)
/**
struct TestSubscriberNoop final : public CValidationInterface {
void BlockChecked(const CBlock&, const BlockValidationState&) override {}
};
@@ -34,9 +33,9 @@ BOOST_AUTO_TEST_CASE(unregister_validation_interface_race)
std::thread sub{[&] {
// keep going for about 1 sec, which is 250k iterations
for (int i = 0; i < 250000; i++) {
TestSubscriberNoop sub{};
RegisterValidationInterface(&sub);
UnregisterValidationInterface(&sub);
auto sub = std::make_shared<TestSubscriberNoop>();
RegisterSharedValidationInterface(sub);
UnregisterSharedValidationInterface(sub);
}
// tell the other thread we are done
generate = false;
@@ -46,7 +45,6 @@ BOOST_AUTO_TEST_CASE(unregister_validation_interface_race)
sub.join();
BOOST_CHECK(!generate);
}
*/
class TestInterface : public CValidationInterface
{