highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-12 23:18:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

util: Avoid invalid integer negation in FormatMoney: make FormatMoney(const CAmount& n) well-defined also when n is std::numeric_limits<CAmount>::min()

Browse Source
This commit is contained in:
practicalswift
2020-11-16 15:42:36 +00:00
parent b9f41df1ea
commit 7cc75c9ba3
4 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/util/moneystr.cpp
View File

@@ -9,13 +9,17 @@
#include <util/strencodings.h>
#include <util/string.h>
std::string FormatMoney(const CAmount& n)
std::string FormatMoney(const CAmount n)
{
// Note: not using straight sprintf here because we do NOT want
// localized number formatting.
int64_t n_abs = (n > 0 ? n : -n);
int64_t quotient = n_abs/COIN;
int64_t remainder = n_abs%COIN;
static_assert(COIN > 1);
int64_t quotient = n / COIN;
int64_t remainder = n % COIN;
if (n < 0) {
quotient = -quotient;
remainder = -remainder;
}
std::string str = strprintf("%d.%08d", quotient, remainder);
// Right-trim excess zeros before the decimal point: