mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-20 23:29:12 +01:00
mining: ensure witness commitment check in submitBlock
When an IPC client requests a new block template via the Mining interface, we hold on to its CBlock. That way when they call submitSolution() we can modify it in place, rather than having to reconstruct the full block like the submitblock RPC does. Before this commit however we forgot to invalidate m_checked_witness_commitment, which we should since the client brings a new coinbase. This would cause us to accept an invalid chaintip. Fix this and add a test to confirm that we now reject such a block. As a sanity check, we add a second node to the test and confirm that will accept our mined block. Note that the IPC code takes the coinbase as provided, unlike the submitblock RPC which calls UpdateUncommittedBlockStructures() and adds witness commitment to the coinbase if it was missing. Although that could have been an alternative fix, we instead document that IPC clients are expected to provide the full coinbase including witness commitment.
This commit is contained in:
@@ -452,6 +452,11 @@ void AddMerkleRootAndCoinbase(CBlock& block, CTransactionRef coinbase, uint32_t
|
||||
block.nTime = timestamp;
|
||||
block.nNonce = nonce;
|
||||
block.hashMerkleRoot = BlockMerkleRoot(block);
|
||||
|
||||
// Reset cached checks
|
||||
block.m_checked_witness_commitment = false;
|
||||
block.m_checked_merkle_root = false;
|
||||
block.fChecked = false;
|
||||
}
|
||||
|
||||
std::unique_ptr<CBlockTemplate> WaitAndCreateNewBlock(ChainstateManager& chainman,
|
||||
|
||||
Reference in New Issue
Block a user