highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-13 01:07:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: verify node skips loading legacy wallets during startup

Browse Source
This commit is contained in:
furszy
2025-05-12 20:46:15 -04:00
parent 9f94de5bb5
commit 86e1111239
1 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
test/functional/wallet_backwards_compatibility.py
View File

@ -14,6 +14,7 @@ Use only the latest patch version of each release, unless a test specifically
needs an older patch version. needs an older patch version.
""" """
import json
import os import os
import shutil import shutil
@ -161,6 +162,38 @@ class BackwardsCompatibilityTest(BitcoinTestFramework):
except ImportError: except ImportError:
self.log.warning("sqlite3 module not available, skipping lack of keymeta records check") self.log.warning("sqlite3 module not available, skipping lack of keymeta records check")
def test_ignore_legacy_during_startup(self, legacy_nodes, node_master):
self.log.info("Test that legacy wallets are ignored during startup on v29+")
legacy_node = legacy_nodes[0]
wallet_name = f"legacy_up_{legacy_node.version}"
legacy_node.loadwallet(wallet_name)
legacy_wallet = legacy_node.get_wallet_rpc(wallet_name)
# Move legacy wallet to latest node
wallet_path = node_master.wallets_path / wallet_name
wallet_path.mkdir()
legacy_wallet.backupwallet(wallet_path / "wallet.dat")
legacy_wallet.unloadwallet()
# Write wallet so it is automatically loaded during init
settings_path = node_master.chain_path / "settings.json"
with settings_path.open("w") as fp:
json.dump({"wallet": [wallet_name]}, fp)
# Restart latest node and verify that the legacy wallet load is skipped without exiting early during init.
self.restart_node(node_master.index, extra_args=[])
# Ensure we receive the warning message and clear the stderr pipe.
node_master.stderr.seek(0)
warning_msg = node_master.stderr.read().decode('utf-8').strip()
assert "The wallet appears to be a Legacy wallet, please use the wallet migration tool (migratewallet RPC or the GUI option)" in warning_msg
node_master.stderr.truncate(0), node_master.stderr.seek(0) # reset buffer
# Verify the node is still running (no shutdown occurred during startup)
node_master.getblockcount()
# Reset settings for any subsequent test
os.remove(settings_path)
def run_test(self): def run_test(self):
node_miner = self.nodes[0] node_miner = self.nodes[0]
node_master = self.nodes[1] node_master = self.nodes[1]
@ -381,6 +414,7 @@ class BackwardsCompatibilityTest(BitcoinTestFramework):
assert_raises_rpc_error(-18, "The wallet appears to be a Legacy wallet, please use the wallet migration tool (migratewallet RPC or the GUI option)", node_master.restorewallet, wallet_name, backup_path) assert_raises_rpc_error(-18, "The wallet appears to be a Legacy wallet, please use the wallet migration tool (migratewallet RPC or the GUI option)", node_master.restorewallet, wallet_name, backup_path)
self.test_v22_inactivehdchain_path() self.test_v22_inactivehdchain_path()
self.test_ignore_legacy_during_startup(legacy_nodes, node_master)
if __name__ == '__main__': if __name__ == '__main__':
BackwardsCompatibilityTest(__file__).main() BackwardsCompatibilityTest(__file__).main()