fix converttopsbt permitsigdata arg, add basic test

This commit is contained in:
Gregory Sanders
2018-09-29 22:09:15 -04:00
parent c9327306b5
commit 88a79cb436
2 changed files with 4 additions and 1 deletions

View File

@@ -1669,7 +1669,7 @@ UniValue converttopsbt(const JSONRPCRequest& request)
// Remove all scriptSigs and scriptWitnesses from inputs
for (CTxIn& input : tx.vin) {
if ((!input.scriptSig.empty() || !input.scriptWitness.IsNull()) && (request.params[1].isNull() || (!request.params[1].isNull() && request.params[1].get_bool()))) {
if ((!input.scriptSig.empty() || !input.scriptWitness.IsNull()) && !permitsigdata) {
throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "Inputs must not have scriptSigs and scriptWitnesses");
}
input.scriptSig.clear();