highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-04 04:32:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: prepare cltv_invalidate to test all failure reasons in feature_cltv.py

Browse Source 
only the "top item on the stack is less than 0" is used in the test right now
This commit is contained in:
Sebastian Falbesoner
2020-08-25 09:33:04 +02:00
parent ce994e1202
commit 8d0ce50c48
1 changed files with 27 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
test/functional/feature_cltv.py
View File

@ -56,23 +56,35 @@ def cltv_modify_tx(node, tx, prepend_scriptsig, nsequence=None, nlocktime=None):
return new_tx return new_tx
def cltv_invalidate(tx): def cltv_invalidate(node, tx, failure_reason):
'''Modify the signature in vin 0 of the tx to fail CLTV # Modify the signature in vin 0 and nSequence/nLockTime of the tx to fail CLTV
#
# According to BIP65, OP_CHECKLOCKTIMEVERIFY can fail due the following reasons:
# 1) the stack is empty
# 2) the top item on the stack is less than 0
# 3) the lock-time type (height vs. timestamp) of the top stack item and the
# nLockTime field are not the same
# 4) the top stack item is greater than the transaction's nLockTime field
# 5) the nSequence field of the txin is 0xffffffff
assert failure_reason in range(5)
scheme = [
# | Script to prepend to scriptSig | nSequence | nLockTime |
# +-------------------------------------------------+------------+--------------+
[[OP_CHECKLOCKTIMEVERIFY], None, None],
[[OP_1NEGATE, OP_CHECKLOCKTIMEVERIFY, OP_DROP], None, None],
[[CScriptNum(1000), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, 1296688602], # timestamp of genesis block
[[CScriptNum(1000), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, 500],
[[CScriptNum(500), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0xffffffff, 500],
][failure_reason]
Prepends -1 CLTV DROP in the scriptSig itself. return cltv_modify_tx(node, tx, prepend_scriptsig=scheme[0], nsequence=scheme[1], nlocktime=scheme[2])
TODO: test more ways that transactions using CLTV could be invalid (eg
locktime requirements fail, sequence time requirements fail, etc).
'''
cltv_modify_tx(None, tx, [OP_1NEGATE, OP_CHECKLOCKTIMEVERIFY, OP_DROP])
def cltv_validate(node, tx, height): def cltv_validate(node, tx, height):
'''Modify the signature in vin 0 of the tx to pass CLTV # Modify the signature in vin 0 and nSequence/nLockTime of the tx to pass CLTV
Prepends <height> CLTV DROP in the scriptSig, and sets scheme = [[CScriptNum(height), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, height]
the locktime to height'''
return cltv_modify_tx(node, tx, [CScriptNum(height), OP_CHECKLOCKTIMEVERIFY, OP_DROP], return cltv_modify_tx(node, tx, prepend_scriptsig=scheme[0], nsequence=scheme[1], nlocktime=scheme[2])
nsequence=0, nlocktime=height)
class BIP65Test(BitcoinTestFramework): class BIP65Test(BitcoinTestFramework):
@ -110,7 +122,7 @@ class BIP65Test(BitcoinTestFramework):
spendtx = create_transaction(self.nodes[0], self.coinbase_txids[0], spendtx = create_transaction(self.nodes[0], self.coinbase_txids[0],
self.nodeaddress, amount=1.0) self.nodeaddress, amount=1.0)
cltv_invalidate(spendtx) spendtx = cltv_invalidate(self.nodes[0], spendtx, 1)
spendtx.rehash() spendtx.rehash()
tip = self.nodes[0].getbestblockhash() tip = self.nodes[0].getbestblockhash()
@ -143,7 +155,7 @@ class BIP65Test(BitcoinTestFramework):
spendtx = create_transaction(self.nodes[0], self.coinbase_txids[1], spendtx = create_transaction(self.nodes[0], self.coinbase_txids[1],
self.nodeaddress, amount=1.0) self.nodeaddress, amount=1.0)
cltv_invalidate(spendtx) spendtx = cltv_invalidate(self.nodes[0], spendtx, 1)
spendtx.rehash() spendtx.rehash()
# First we show that this tx is valid except for CLTV by getting it # First we show that this tx is valid except for CLTV by getting it