mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-04-20 11:49:07 +02:00
fuzz: limit the number of sub-fragments per fragment for descriptors
This target may call into logic quadratic over the number of sub-fragments. Limit the number of sub-fragments to keep the runtime reasonable. Thanks to Marco Falke for reporting the fuzz timeouts with a minimized input.
This commit is contained in:
@@ -4,6 +4,8 @@
|
||||
|
||||
#include <test/fuzz/util/descriptor.h>
|
||||
|
||||
#include <stack>
|
||||
|
||||
void MockedDescriptorConverter::Init() {
|
||||
// The data to use as a private key or a seed for an xprv.
|
||||
std::array<std::byte, 32> key_data{std::byte{1}};
|
||||
@@ -84,3 +86,27 @@ bool HasDeepDerivPath(const FuzzBufferType& buff, const int max_depth)
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
bool HasTooManySubFrag(const FuzzBufferType& buff, const int max_subs, const size_t max_nested_subs)
|
||||
{
|
||||
// We use a stack because there may be many nested sub-frags.
|
||||
std::stack<int> counts;
|
||||
for (const auto& ch: buff) {
|
||||
// The fuzzer may generate an input with a ton of parentheses. Rule out pathological cases.
|
||||
if (counts.size() > max_nested_subs) return true;
|
||||
|
||||
if (ch == '(') {
|
||||
// A new fragment was opened, create a new sub-count for it and start as one since any fragment with
|
||||
// parentheses has at least one sub.
|
||||
counts.push(1);
|
||||
} else if (ch == ',' && !counts.empty()) {
|
||||
// When encountering a comma, account for an additional sub in the last opened fragment. If it exceeds the
|
||||
// limit, bail.
|
||||
if (++counts.top() > max_subs) return true;
|
||||
} else if (ch == ')' && !counts.empty()) {
|
||||
// Fragment closed! Drop its sub count and resume to counting the number of subs for its parent.
|
||||
counts.pop();
|
||||
}
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user