highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-16 11:53:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

util: Don't allow DecodeBase64(...) of strings with embedded NUL characters

Browse Source
This commit is contained in:
practicalswift 2019-12-16 09:00:08 +00:00
parent ccc53e43c5
commit 93cc18b0f6
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/strencodings.cpp
View File

@ -191,6 +191,12 @@ std::vector<unsigned char> DecodeBase64(const char* p, bool* pf_invalid)
std::string DecodeBase64(const std::string& str, bool* pf_invalid) std::string DecodeBase64(const std::string& str, bool* pf_invalid)
{ {
if (!ValidAsCString(str)) {
if (pf_invalid) {
*pf_invalid = true;
}
return {};
}
std::vector<unsigned char> vchRet = DecodeBase64(str.c_str(), pf_invalid); std::vector<unsigned char> vchRet = DecodeBase64(str.c_str(), pf_invalid);
return std::string((const char*)vchRet.data(), vchRet.size()); return std::string((const char*)vchRet.data(), vchRet.size());
} }