highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-13 05:10:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

[net processing] Remove unnecesary nNewHeight variable in UpdatedBlockTip()

Browse Source
This commit is contained in:
John Newbery 2020-12-11 10:35:32 +00:00
parent 8b57013473
commit 94d2cc35be
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/net_processing.cpp
View File

@ -1293,8 +1293,7 @@ void PeerManager::NewPoWValidBlock(const CBlockIndex *pindex, const std::shared_
* in ::ChainActive() to our peers. * in ::ChainActive() to our peers.
*/ */
void PeerManager::UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload) { void PeerManager::UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload) {
const int nNewHeight = pindexNew->nHeight; m_connman.SetBestHeight(pindexNew->nHeight);
m_connman.SetBestHeight(nNewHeight);
SetServiceFlagsIBDCache(!fInitialDownload); SetServiceFlagsIBDCache(!fInitialDownload);
// Relay inventory, but don't relay old inventory during initial block download. // Relay inventory, but don't relay old inventory during initial block download.
@ -1311,7 +1310,7 @@ void PeerManager::UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockInde
break; break;
} }
} }
m_connman.ForEachNode([nNewHeight, &vHashes](CNode* pnode) { m_connman.ForEachNode([&vHashes](CNode* pnode) {
LOCK(pnode->cs_inventory); LOCK(pnode->cs_inventory);
for (const uint256& hash : reverse_iterate(vHashes)) { for (const uint256& hash : reverse_iterate(vHashes)) {
pnode->vBlockHashesToAnnounce.push_back(hash); pnode->vBlockHashesToAnnounce.push_back(hash);