common: Don't terminate on null character in UrlDecode

The previous behavior was the result of casting the result returned from the libevent function evhttp_uridecode to std:string but this was probably not intended.
This commit is contained in:
Fabian Jahr
2024-04-21 21:48:05 +02:00
parent 099fa57151
commit 992c714451
2 changed files with 4 additions and 7 deletions

View File

@@ -25,11 +25,6 @@ std::string UrlDecode(std::string_view url_encoded)
// Only if there is no error and the pointer is set to the end of
// the string, we can be sure both characters were valid hex
if (ec == std::errc{} && p == url_encoded.data() + i + 3) {
// A null character terminates the string
if (decoded_value == 0) {
return res;
}
res += static_cast<char>(decoded_value);
// Next two characters are part of the percent encoding
i += 2;