highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-03 17:54:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#22270: test: Add bitcoin-util tests (+refactors)

Browse Source 
fa4017e7a0 refactor: Pass grind args vector as const reference (MarcoFalke)
fa08bc288f Remove gArgs from AppInitUtil (MarcoFalke)
fa751a47ff Remove unused OptionsCategory arg from AddCommand (MarcoFalke)
fa3c1eee7f Remove unused includes from bitcoin-util (MarcoFalke)
fa304929e2 test: Add bitcoin-util tests (MarcoFalke)
fa831e709a build_msvc: Add bitcoin-util.exe (MarcoFalke)

Pull request description:

  bitcoin-util has no tests

  See https://marcofalke.github.io/btc_cov/total.coverage/src/bitcoin-util.cpp.gcov.html (Coverage report showing 0%)

ACKs for top commit:
  klementtan:
    Code review and tested ACK fa4017e7a0
  theStack:
    Tested ACK fa4017e7a0
  jamesob:
    reACK fa4017e7a0 ([`jamesob/ackr/22270.1.MarcoFalke.test_add_bitcoin_util_te`](https://github.com/jamesob/bitcoin/tree/ackr/22270.1.MarcoFalke.test_add_bitcoin_util_te))

Tree-SHA512: 68e2791239bc48d28fbb6394155c39ea0357a96ec7e4896ca579feeef1a803657165a0ef9fa3cf6e2a381e5b0ca0dafa1b594158303a04997db784201d8dd66d
This commit is contained in:
MarcoFalke
2021-06-24 09:41:48 +02:00
parent 7317e14a44 fa4017e7a0
commit a196c89317
7 changed files with 96 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
test/util/data/bitcoin-util-test.json
View File

@@ -1,4 +1,34 @@
[
{ "exec": "./bitcoin-util",
"args": ["foo"],
"return_code": 1,
"error_txt": "Error parsing command line arguments: Invalid command 'foo'",
"description": ""
},
{ "exec": "./bitcoin-util",
"args": ["help"],
"return_code": 1,
"error_txt": "Error parsing command line arguments: Invalid command 'help'",
"description": "`help` raises an error. Use `-help`"
},
{ "exec": "./bitcoin-util",
"args": ["grind"],
"return_code": 1,
"error_txt": "Must specify block header to grind",
"description": ""
},
{ "exec": "./bitcoin-util",
"args": ["grind", "1", "2"],
"return_code": 1,
"error_txt": "Must specify block header to grind",
"description": ""
},
{ "exec": "./bitcoin-util",
"args": ["grind", "aa"],
"return_code": 1,
"error_txt": "Could not decode block header",
"description": ""
},
{ "exec": "./bitcoin-tx",
"args": ["-create", "nversion=1"],
"output_cmp": "blanktxv1.hex",