highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-11 06:28:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

[doc] replace mentions of v3 with TRUC

Browse Source 
Keep mentions of v3 in debug strings to help people who might not know
that TRUC is applied when version=3.
Also keep variable names in tests, as it is less verbose to keep v3 and v2.
This commit is contained in:
glozow
2024-06-11 13:37:05 +01:00
parent 089b5757df
commit a573dd2617
9 changed files with 131 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/functional/wallet_create_tx.py
View File

@@ -114,16 +114,16 @@ class CreateTxWalletTest(BitcoinTestFramework):
self.log.info('Check wallet does not create transactions with version=3 yet')
wallet_rpc = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
self.nodes[0].createwallet("v3")
wallet_v3 = self.nodes[0].get_wallet_rpc("v3")
self.nodes[0].createwallet("version3")
wallet_v3 = self.nodes[0].get_wallet_rpc("version3")
tx_data = wallet_rpc.send(outputs=[{wallet_v3.getnewaddress(): 25}], options={"change_position": 0})
wallet_tx_data = wallet_rpc.gettransaction(tx_data["txid"])
tx_current_version = tx_from_hex(wallet_tx_data["hex"])
# While v3 transactions are standard, the CURRENT_VERSION is 2.
# While version=3 transactions are standard, the CURRENT_VERSION is 2.
# This test can be removed if CURRENT_VERSION is changed, and replaced with tests that the
# wallet handles v3 rules properly.
# wallet handles TRUC rules properly.
assert_equal(tx_current_version.version, 2)
wallet_v3.unloadwallet()