mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-06-29 02:11:24 +02:00
Merge #20267: Disable and fix tests for when BDB is not compiled
49797c3ccf
tests: Disable bdb dump test when no bdb (Andrew Chow)1194cf9269
Fix wallet_send.py wallet setup to work with descriptors (Andrew Chow)fbaea7bfe4
Require legacy wallet for wallet_upgradewallet.py (Andrew Chow)b1b679e0ab
Explicitly mark legacy wallet tests as such (Andrew Chow)09514e1bef
Setup wallets for interface_zmq.py (Andrew Chow)4d03ef9a73
Use MiniWallet in rpc_net.py (Andrew Chow)4de23824b0
Setup wallets for interface_bitcoin_cli.py (Andrew Chow)7c71c627d2
Setup wallets with descriptors for feature_notifications (Andrew Chow)1f1bef8dba
Have feature_filelock.py test both bdb and sqlite, depending on compiled (Andrew Chow)c77975abc0
Disable upgrades tests that require BDB if BDB is not compiled (Andrew Chow)1f20cac9d4
Disable wallet_descriptor.py bdb format check if BDB is not compiled (Andrew Chow)3641597d7e
tests: Don't make any wallets unless wallet is required (Andrew Chow)b9b88f57a9
Skip legacy wallet reliant tests if BDB is not compiled (Andrew Chow)6f36242389
tests: Set descriptors default based on compilation (Andrew Chow) Pull request description: This PR fixes tests for when BDB is not compiled. Tests which rely on or test legacy wallet behavior are disabled and skipped when BDB is not compiled. For the components of some tests that are for legacy wallet things, those parts of the tests are skipped. For the majority of tests, changes are made so that they can be run with either legacy wallets or descriptor wallets without materially effecting the test. Most tests only need the wallet for balance and transactions, so the type of wallet is not an important part of those tests. Additionally, some tests are wallet agnostic and modified to instead use the test framework's MiniWallet. ACKs for top commit: laanwj: ACK49797c3ccf
ryanofsky: Code review ACK49797c3ccf
. Only change since last review is dropping last commit. Previous review w/ suggestions for future followup is https://github.com/bitcoin/bitcoin/pull/20267#pullrequestreview-581508843 Tree-SHA512: 69659f8a81fb437ecbca962f4082c12835282dbf1fba7d9952f727a49e01981d749af9b09feda1c8ca737516c7d7a08ef17e782795df3fa69892d5021b41c1ed
This commit is contained in:
@ -350,7 +350,8 @@ class ToolWalletTest(BitcoinTestFramework):
|
||||
|
||||
self.log.info('Checking createfromdump')
|
||||
self.do_tool_createfromdump("load", "wallet.dump")
|
||||
self.do_tool_createfromdump("load-bdb", "wallet.dump", "bdb")
|
||||
if self.is_bdb_compiled():
|
||||
self.do_tool_createfromdump("load-bdb", "wallet.dump", "bdb")
|
||||
if self.is_sqlite_compiled():
|
||||
self.do_tool_createfromdump("load-sqlite", "wallet.dump", "sqlite")
|
||||
|
||||
|
Reference in New Issue
Block a user