test: remove unnecessary block rehashing prior to solving

Solving a block involves continously rehashing it, i.e. any extra
calls to rehash it before are not necessary and can be dropped.
This commit is contained in:
Sebastian Falbesoner
2021-11-12 18:29:43 +01:00
parent c9dd5c8d6e
commit a9872e1478
11 changed files with 0 additions and 20 deletions

View File

@@ -335,7 +335,6 @@ class BIP68Test(BitcoinTestFramework):
# tx3 to be removed.
for i in range(2):
block = create_block(tmpl=tmpl, ntime=cur_time)
block.rehash()
block.solve()
tip = block.sha256
assert_equal(None if i == 1 else 'inconclusive', self.nodes[0].submitblock(block.serialize().hex()))
@@ -392,7 +391,6 @@ class BIP68Test(BitcoinTestFramework):
block = create_block(tmpl=self.nodes[0].getblocktemplate(NORMAL_GBT_REQUEST_PARAMS))
block.vtx.extend([tx1, tx2, tx3])
block.hashMerkleRoot = block.calc_merkle_root()
block.rehash()
add_witness_commitment(block)
block.solve()