highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-30 04:32:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

validation: drop testnet3 comment about BIP34

Browse Source
This commit is contained in:
Sjors Provoost 2025-03-03 13:25:31 -05:00
parent 5462b35f90
commit aae6208eb1
No known key found for this signature in database
GPG Key ID: 57FF9BDBCC301009
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/validation.cpp
View File

@ -2589,10 +2589,6 @@ bool Chainstate::ConnectBlock(const CBlock& block, BlockValidationState& state,
// coinbase. The two historical BIP30 violations often provide a confusing // coinbase. The two historical BIP30 violations often provide a confusing
// edge case when manipulating the UTXO and it would be simpler not to have // edge case when manipulating the UTXO and it would be simpler not to have
// another edge case to deal with. // another edge case to deal with.
// testnet3 has no blocks before the BIP34 height with indicated heights
// post BIP34 before approximately height 486,000,000. After block
// 1,983,702 testnet3 starts doing unnecessary BIP30 checking again.
assert(pindex->pprev); assert(pindex->pprev);
CBlockIndex* pindexBIP34height = pindex->pprev->GetAncestor(params.GetConsensus().BIP34Height); CBlockIndex* pindexBIP34height = pindex->pprev->GetAncestor(params.GetConsensus().BIP34Height);
//Only continue to enforce if we're below BIP34 activation height or the block hash at that height doesn't correspond. //Only continue to enforce if we're below BIP34 activation height or the block hash at that height doesn't correspond.