qt, refactor: Use enum type as switch argument in AddressTableModel

src/qt/addresstablemodel.cpp

@@ -198,42 +198,38 @@ QVariant AddressTableModel::data(const QModelIndex &index, int role) const
 
     AddressTableEntry *rec = static_cast<AddressTableEntry*>(index.internalPointer());
 
-    if(role == Qt::DisplayRole || role == Qt::EditRole)
+    const auto column = static_cast<ColumnIndex>(index.column());
-    {
+    if (role == Qt::DisplayRole || role == Qt::EditRole) {
-        switch(index.column())
+        switch (column) {
-        {
         case Label:
-            if(rec->label.isEmpty() && role == Qt::DisplayRole)
+            if (rec->label.isEmpty() && role == Qt::DisplayRole) {
-            {
                 return tr("(no label)");
-            }
+            } else {
-            else
-            {
                 return rec->label;
             }
         case Address:
             return rec->address;
-        }
+        } // no default case, so the compiler can warn about missing cases
-    }
+        assert(false);
-    else if (role == Qt::FontRole)
+    } else if (role == Qt::FontRole) {
-    {
+        switch (column) {
-        QFont font;
+        case Label:
-        if(index.column() == Address)
+            return QFont();
-        {
+        case Address:
-            font = GUIUtil::fixedPitchFont();
+            return GUIUtil::fixedPitchFont();
-        }
+        } // no default case, so the compiler can warn about missing cases
-        return font;
+        assert(false);
-    }
+    } else if (role == TypeRole) {
-    else if (role == TypeRole)
-    {
         switch(rec->type)
         {
         case AddressTableEntry::Sending:
             return Send;
         case AddressTableEntry::Receiving:
             return Receive;
-        default: break;
+        case AddressTableEntry::Hidden:
-        }
+            return {};
+        } // no default case, so the compiler can warn about missing cases
+        assert(false);
     }
     return QVariant();
 }