qt, refactor: Use enum type as switch argument in AddressTableModel

This commit is contained in:
Hennadii Stepanov 2020-12-25 22:17:37 +02:00
parent 08eec6907a
commit ab8a747d1c
No known key found for this signature in database
GPG Key ID: 410108112E7EA81F

View File

@ -198,42 +198,38 @@ QVariant AddressTableModel::data(const QModelIndex &index, int role) const
AddressTableEntry *rec = static_cast<AddressTableEntry*>(index.internalPointer()); AddressTableEntry *rec = static_cast<AddressTableEntry*>(index.internalPointer());
if(role == Qt::DisplayRole || role == Qt::EditRole) const auto column = static_cast<ColumnIndex>(index.column());
{ if (role == Qt::DisplayRole || role == Qt::EditRole) {
switch(index.column()) switch (column) {
{
case Label: case Label:
if(rec->label.isEmpty() && role == Qt::DisplayRole) if (rec->label.isEmpty() && role == Qt::DisplayRole) {
{
return tr("(no label)"); return tr("(no label)");
} } else {
else
{
return rec->label; return rec->label;
} }
case Address: case Address:
return rec->address; return rec->address;
} } // no default case, so the compiler can warn about missing cases
} assert(false);
else if (role == Qt::FontRole) } else if (role == Qt::FontRole) {
{ switch (column) {
QFont font; case Label:
if(index.column() == Address) return QFont();
{ case Address:
font = GUIUtil::fixedPitchFont(); return GUIUtil::fixedPitchFont();
} } // no default case, so the compiler can warn about missing cases
return font; assert(false);
} } else if (role == TypeRole) {
else if (role == TypeRole)
{
switch(rec->type) switch(rec->type)
{ {
case AddressTableEntry::Sending: case AddressTableEntry::Sending:
return Send; return Send;
case AddressTableEntry::Receiving: case AddressTableEntry::Receiving:
return Receive; return Receive;
default: break; case AddressTableEntry::Hidden:
} return {};
} // no default case, so the compiler can warn about missing cases
assert(false);
} }
return QVariant(); return QVariant();
} }