highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-02 01:04:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#34544: wallet: Disallow wallet names that are paths including .. and . elements

Browse Source 
eed7af666b doc: Add release note for disallowing some wallet path names (David Gumberg)
3d7f0e4ed5 wallettool: Use GetWalletPath to determine the wallet path (Ava Chow)
2b0dc0d228 wallet: Disallow . and .. from wallet names (Ava Chow)

Pull request description:

  Wallet names including `..` and `.` are unintuitive and can lead to various issues, see #34497

  This disallows creating or loading wallets that have any path elements that are `..` or `.`, including any present in an absolute path. This does not disallow relative paths altogether but rather limits them to only being subdirectories of the wallets directory.

ACKs for top commit:
  davidgumberg:
    crACK eed7af666b
  w0xlt:
    ACK eed7af666b
  arejula27:
    ACK eed7af666b

Tree-SHA512: bec5e54369061eb630d9afb94701badce09e8beb63686cf714016466fc01653d4841030fc10fcd14d44e6b1022c0994cb32253d80533807704d9e11eda2423ff
This commit is contained in:
merge-script
2026-05-02 10:58:15 +02:00
parent db98e357d3 eed7af666b
commit b1ff4773ba
6 changed files with 55 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
doc/release-notes-34544.md Normal file
View File

@@ -0,0 +1,7 @@
Wallet
------
- Wallets names that are relative paths including `..` and `.` elements, and
wallets named `/` are no longer allowed. Any users that depended on this
behavior can instead use absolute paths to their wallet or move their wallet
to a safer path.