highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-30 18:35:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

net: convert standalone IsSelectableSocket() to Sock::IsSelectable()

Browse Source 
This makes the callers mockable.
This commit is contained in:
Vasil Dimov
2021-04-13 14:29:14 +02:00
parent 5db7d2ca0a
commit b4bac55679
7 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/util/sock.cpp
View File

@@ -117,11 +117,12 @@ int Sock::GetSockName(sockaddr* name, socklen_t* name_len) const
return getsockname(m_socket, name, name_len);
}
bool IsSelectableSocket(const SOCKET& s) {
bool Sock::IsSelectable() const
{
#if defined(USE_POLL) || defined(WIN32)
return true;
#else
return (s < FD_SETSIZE);
return m_socket < FD_SETSIZE;
#endif
}
@@ -193,10 +194,10 @@ bool Sock::WaitMany(std::chrono::milliseconds timeout, EventsPerSock& events_per
SOCKET socket_max{0};
for (const auto& [sock, events] : events_per_sock) {
const auto& s = sock->m_socket;
if (!IsSelectableSocket(s)) {
if (!sock->IsSelectable()) {
return false;
}
const auto& s = sock->m_socket;
if (events.requested & RECV) {
FD_SET(s, &recv);
}