highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-08-25 19:11:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

[doc] reword comments in test_mid_package_replacement

Browse Source 
The comment about eviction seems to be erroneously copy-pasted. Reword
another comment for clarity.
This commit is contained in:
glozow
2025-07-16 13:27:23 -04:00
parent f3a613aa5b
commit b6d4688f77
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/functional/mempool_limit.py
View File

@@ -191,9 +191,7 @@ class MempoolLimitTest(BitcoinTestFramework):
current_info = node.getmempoolinfo() current_info = node.getmempoolinfo()
mempoolmin_feerate = current_info["mempoolminfee"] mempoolmin_feerate = current_info["mempoolminfee"]
# Mempool transaction which is evicted due to being at the "bottom" of the mempool when the # Mempool transaction is replaced by a package transaction.
# mempool overflows and evicts by descendant score. It's important that the eviction doesn't
# happen in the middle of package evaluation, as it can invalidate the coins cache.
double_spent_utxo = self.wallet.get_utxo(confirmed_only=True) double_spent_utxo = self.wallet.get_utxo(confirmed_only=True)
replaced_tx = self.wallet.send_self_transfer( replaced_tx = self.wallet.send_self_transfer(
from_node=node, from_node=node,
@@ -205,8 +203,8 @@ class MempoolLimitTest(BitcoinTestFramework):
assert replaced_tx["txid"] in node.getrawmempool() assert replaced_tx["txid"] in node.getrawmempool()
# This parent spends the above mempool transaction that exists when its inputs are first # This parent spends the above mempool transaction that exists when its inputs are first
# looked up, but disappears later. It is rejected for being too low fee (but eligible for # looked up, but will disappear if the replacement occurs. It is rejected for being too low fee (but eligible for
# reconsideration), and its inputs are cached. When the mempool transaction is evicted, its # reconsideration), and its inputs are cached. When the mempool transaction is replaced, its
# coin is no longer available, but the cache could still contain the tx. # coin is no longer available, but the cache could still contain the tx.
cpfp_parent = self.wallet.create_self_transfer( cpfp_parent = self.wallet.create_self_transfer(
utxo_to_spend=replaced_tx["new_utxo"], utxo_to_spend=replaced_tx["new_utxo"],