highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-09-20 18:41:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge #21669: test: Remove spurious double lock tsan suppressions by bumping to clang-12

Browse Source 
fadea0bf37 Revert "test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles" (MarcoFalke)
fadbd99885 test: Remove spurious double lock tsan suppressions by bumping to clang-12 (MarcoFalke)

Pull request description:

  The double lock warnings appeared in #19041, but they didn't make any sense. Also, our sync module would detect double locks, if there were any.

  Bumping to clang-12 allows us to remove the spurious suppressions needed to run the tests, so do that.

ACKs for top commit:
  practicalswift:
    cr ACK fadea0bf37 assuming CI passes and more specifically that newer Clang agrees that these TSan suppressions are no longer needed.

Tree-SHA512: c411221a4b74d0af6ca8d686639b4f40b41c15906ccbb6647e8d569d6ab088264faafe075e1ac9523d5c0024b85f15a597bb3eedc7f07d4f5816245f75cfc08b
This commit is contained in:
MarcoFalke
2021-04-14 09:20:45 +02:00
parent e7af2f35af fadea0bf37
commit b8e5bbdf93
3 changed files with 3 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.cirrus.yml
View File

@@ -120,10 +120,10 @@ task:
FILE_ENV: "./ci/test/00_setup_env_native_qt5.sh" FILE_ENV: "./ci/test/00_setup_env_native_qt5.sh"
task: task:
name: '[depends, sanitizers: thread (TSan), no gui] [focal]' name: '[depends, sanitizers: thread (TSan), no gui] [hirsute]'
<< : *GLOBAL_TASK_TEMPLATE << : *GLOBAL_TASK_TEMPLATE
container: container:
image: ubuntu:focal image: ubuntu:hirsute
cpu: 6 # Increase CPU and Memory to avoid timeout cpu: 6 # Increase CPU and Memory to avoid timeout
memory: 24G memory: 24G
env: env:

2
ci/test/00_setup_env_native_tsan.sh
View File

@@ -7,7 +7,7 @@
export LC_ALL=C.UTF-8 export LC_ALL=C.UTF-8
export CONTAINER_NAME=ci_native_tsan export CONTAINER_NAME=ci_native_tsan
export DOCKER_NAME_TAG=ubuntu:20.04 export DOCKER_NAME_TAG=ubuntu:hirsute
export PACKAGES="clang llvm libc++abi-dev libc++-dev python3-zmq" export PACKAGES="clang llvm libc++abi-dev libc++-dev python3-zmq"
export DEP_OPTS="CC=clang CXX='clang++ -stdlib=libc++'" export DEP_OPTS="CC=clang CXX='clang++ -stdlib=libc++'"
export GOAL="install" export GOAL="install"

19
test/sanitizer_suppressions/tsan
View File

@@ -3,31 +3,12 @@
# #
# https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions # https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions
# double locks (TODO fix)
mutex:g_genesis_wait_mutex
mutex:Interrupt
mutex:CThreadInterrupt
mutex:CConnman::Interrupt
mutex:CConnman::WakeMessageHandler
mutex:CConnman::ThreadOpenConnections
mutex:CConnman::ThreadOpenAddedConnections
mutex:CConnman::SocketHandler
mutex:UpdateTip
mutex:PeerManagerImpl::UpdatedBlockTip
mutex:g_best_block_mutex
# race (TODO fix) # race (TODO fix)
race:CConnman::WakeMessageHandler
race:CConnman::ThreadMessageHandler
race:fHaveGenesis
race:ProcessNewBlock
race:ThreadImport
race:LoadWallet race:LoadWallet
race:WalletBatch::WriteHDChain race:WalletBatch::WriteHDChain
race:BerkeleyBatch race:BerkeleyBatch
race:BerkeleyDatabase race:BerkeleyDatabase
race:DatabaseBatch race:DatabaseBatch
race:leveldb::DBImpl::DeleteObsoleteFiles
race:zmq::* race:zmq::*
race:bitcoin-qt race:bitcoin-qt