sync.h: add REVERSE_LOCK

This commit is contained in:
Anthony Towns
2020-03-01 14:22:37 +10:00
parent 306f71b4eb
commit b9c4260127
3 changed files with 94 additions and 9 deletions

View File

@@ -2,7 +2,7 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <reverselock.h>
#include <sync.h>
#include <test/util/setup_common.h>
#include <boost/test/unit_test.hpp>
@@ -11,21 +11,50 @@ BOOST_FIXTURE_TEST_SUITE(reverselock_tests, BasicTestingSetup)
BOOST_AUTO_TEST_CASE(reverselock_basics)
{
boost::mutex mutex;
boost::unique_lock<boost::mutex> lock(mutex);
Mutex mutex;
WAIT_LOCK(mutex, lock);
BOOST_CHECK(lock.owns_lock());
{
reverse_lock<boost::unique_lock<boost::mutex> > rlock(lock);
REVERSE_LOCK(lock);
BOOST_CHECK(!lock.owns_lock());
}
BOOST_CHECK(lock.owns_lock());
}
BOOST_AUTO_TEST_CASE(reverselock_multiple)
{
Mutex mutex2;
Mutex mutex;
WAIT_LOCK(mutex2, lock2);
WAIT_LOCK(mutex, lock);
// Make sure undoing two locks succeeds
{
REVERSE_LOCK(lock);
BOOST_CHECK(!lock.owns_lock());
REVERSE_LOCK(lock2);
BOOST_CHECK(!lock2.owns_lock());
}
BOOST_CHECK(lock.owns_lock());
BOOST_CHECK(lock2.owns_lock());
}
BOOST_AUTO_TEST_CASE(reverselock_errors)
{
boost::mutex mutex;
boost::unique_lock<boost::mutex> lock(mutex);
Mutex mutex2;
Mutex mutex;
WAIT_LOCK(mutex2, lock2);
WAIT_LOCK(mutex, lock);
#ifdef DEBUG_LOCKORDER
// Make sure trying to reverse lock a previous lock fails
try {
REVERSE_LOCK(lock2);
BOOST_CHECK(false); // REVERSE_LOCK(lock2) succeeded
} catch(...) { }
BOOST_CHECK(lock2.owns_lock());
#endif
// Make sure trying to reverse lock an unlocked lock fails
lock.unlock();
@@ -34,7 +63,7 @@ BOOST_AUTO_TEST_CASE(reverselock_errors)
bool failed = false;
try {
reverse_lock<boost::unique_lock<boost::mutex> > rlock(lock);
REVERSE_LOCK(lock);
} catch(...) {
failed = true;
}
@@ -49,7 +78,7 @@ BOOST_AUTO_TEST_CASE(reverselock_errors)
lock.lock();
BOOST_CHECK(lock.owns_lock());
{
reverse_lock<boost::unique_lock<boost::mutex> > rlock(lock);
REVERSE_LOCK(lock);
BOOST_CHECK(!lock.owns_lock());
}