highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-27 09:21:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

subprocess: Explicitly define move constructor of Streams class

Browse Source 
This suppresses the following warning caused by clang-20.

```
error: definition of implicit copy constructor for 'Streams' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
```

Copy constructor or move constructor is called when std::vector re-allocates
memory. In this case, move constructor should be called, because copying
Streams instances breaks file-descriptor management.

Communication class is modified as well, since it's instance is a member of
Streams class.

Github-Pull: arun11299/cpp-subprocess#107
Rebased-From: 38d98d9d20be50c7187b98ac9bc9a6e66920f6ef
This commit is contained in:
Shunsuke Shimizu 2025-05-01 22:14:29 +01:00 committed by Hennadii Stepanov
parent 174bd43f2e
commit bb9ffea53f
No known key found for this signature in database
GPG Key ID: 410108112E7EA81F
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/util/subprocess.h
View File

@ -770,7 +770,10 @@ class Communication
public:
Communication(Streams* stream): stream_(stream)
{}
void operator=(const Communication&) = delete;
Communication(const Communication&) = delete;
Communication& operator=(const Communication&) = delete;
Communication(Communication&&) = default;
Communication& operator=(Communication&&) = default;
public:
int send(const char* msg, size_t length);
int send(const std::vector<char>& msg);
@ -807,7 +810,10 @@ class Streams
{
public:
Streams():comm_(this) {}
void operator=(const Streams&) = delete;
Streams(const Streams&) = delete;
Streams& operator=(const Streams&) = delete;
Streams(Streams&&) = default;
Streams& operator=(Streams&&) = default;
public:
void setup_comm_channels();