highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-15 12:23:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: MiniWallet: fix tx padding (target_weight) for large sizes, improve accuracy

Browse Source
This commit is contained in:
Sebastian Falbesoner
2024-05-23 18:20:58 +02:00
parent ef44726918
commit c17550bc3a
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/functional/test_framework/wallet.py
View File

@ -33,10 +33,12 @@ from test_framework.messages import (
CTxInWitness, CTxInWitness,
CTxOut, CTxOut,
hash256, hash256,
ser_compact_size,
) )
from test_framework.script import ( from test_framework.script import (
CScript, CScript,
LEAF_VERSION_TAPSCRIPT, LEAF_VERSION_TAPSCRIPT,
OP_1,
OP_NOP, OP_NOP,
OP_RETURN, OP_RETURN,
OP_TRUE, OP_TRUE,
@ -119,13 +121,16 @@ class MiniWallet:
"""Pad a transaction with extra outputs until it reaches a target weight (or higher). """Pad a transaction with extra outputs until it reaches a target weight (or higher).
returns the tx returns the tx
""" """
tx.vout.append(CTxOut(nValue=0, scriptPubKey=CScript([OP_RETURN, b'a']))) tx.vout.append(CTxOut(nValue=0, scriptPubKey=CScript([OP_RETURN])))
# determine number of needed padding bytes by converting weight difference to vbytes
dummy_vbytes = (target_weight - tx.get_weight() + 3) // 4 dummy_vbytes = (target_weight - tx.get_weight() + 3) // 4
tx.vout[-1].scriptPubKey = CScript([OP_RETURN, b'a' * dummy_vbytes]) # compensate for the increase of the compact-size encoded script length
# Lower bound should always be off by at most 3 # (note that the length encoding of the unpadded output script needs one byte)
dummy_vbytes -= len(ser_compact_size(dummy_vbytes)) - 1
tx.vout[-1].scriptPubKey = CScript([OP_RETURN] + [OP_1] * dummy_vbytes)
# Actual weight should be at most 3 higher than target weight
assert_greater_than_or_equal(tx.get_weight(), target_weight) assert_greater_than_or_equal(tx.get_weight(), target_weight)
# Higher bound should always be off by at most 3 + 12 weight (for encoding the length) assert_greater_than_or_equal(target_weight + 3, tx.get_weight())
assert_greater_than_or_equal(target_weight + 15, tx.get_weight())
def get_balance(self): def get_balance(self):
return sum(u['value'] for u in self._utxos) return sum(u['value'] for u in self._utxos)