highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-11 06:28:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

sync: Improve CheckLastCritical()

Browse Source 
This commit adds actual lock stack logging if check fails.
This commit is contained in:
Hennadii Stepanov
2020-09-20 11:33:48 +03:00
parent da957cd62e
commit c5e3e74f70
2 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/reverselock_tests.cpp
View File

@@ -48,12 +48,14 @@ BOOST_AUTO_TEST_CASE(reverselock_errors)
WAIT_LOCK(mutex, lock);
#ifdef DEBUG_LOCKORDER
bool prev = g_debug_lockorder_abort;
g_debug_lockorder_abort = false;
// Make sure trying to reverse lock a previous lock fails
try {
REVERSE_LOCK(lock2);
BOOST_CHECK(false); // REVERSE_LOCK(lock2) succeeded
} catch(...) { }
BOOST_CHECK_EXCEPTION(REVERSE_LOCK(lock2), std::logic_error, HasReason("lock2 was not most recent critical section locked"));
BOOST_CHECK(lock2.owns_lock());
g_debug_lockorder_abort = prev;
#endif
// Make sure trying to reverse lock an unlocked lock fails