highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-08-24 15:21:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: use local CBlockIndex in block read hash mismatch test to avoid data race

Browse Source 
Co-authored-by: stickies-v <stickies-v@protonmail.com>
This commit is contained in:
Lőrinc
2025-08-07 14:14:28 -07:00
parent 2bb06bcaf2
commit cb173b8e93
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/blockmanager_tests.cpp
View File

@@ -139,12 +139,18 @@ BOOST_FIXTURE_TEST_CASE(blockmanager_block_data_availability, TestChain100Setup)
BOOST_FIXTURE_TEST_CASE(blockmanager_readblock_hash_mismatch, TestingSetup) BOOST_FIXTURE_TEST_CASE(blockmanager_readblock_hash_mismatch, TestingSetup)
{ {
CBlockIndex* fake_index{WITH_LOCK(m_node.chainman->GetMutex(), return m_node.chainman->ActiveChain().Tip())}; CBlockIndex index;
fake_index->phashBlock = &uint256::ONE; // invalid block hash {
LOCK(cs_main);
const auto tip{m_node.chainman->ActiveTip()};
index.nStatus = tip->nStatus;
index.nDataPos = tip->nDataPos;
index.phashBlock = &uint256::ONE; // mismatched block hash
}
ASSERT_DEBUG_LOG("GetHash() doesn't match index"); ASSERT_DEBUG_LOG("GetHash() doesn't match index");
CBlock dummy; CBlock block;
BOOST_CHECK(!m_node.chainman->m_blockman.ReadBlock(dummy, *fake_index)); BOOST_CHECK(!m_node.chainman->m_blockman.ReadBlock(block, index));
} }
BOOST_AUTO_TEST_CASE(blockmanager_flush_block_file) BOOST_AUTO_TEST_CASE(blockmanager_flush_block_file)