highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-04 08:51:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: ensure addrman test is finite

Browse Source 
Add a counter to ensure that the error case is bounded rather than leading to a
CI timeout
This commit is contained in:
Amiti Uttarwar 2023-04-25 17:05:23 +01:00
parent b9f1e86f12
commit cd8ef5b3e6
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/addrman_tests.cpp
View File

@ -239,8 +239,9 @@ BOOST_AUTO_TEST_CASE(addrman_select_by_network)
// ensure that both new and tried table are selected from // ensure that both new and tried table are selected from
bool new_selected{false}; bool new_selected{false};
bool tried_selected{false}; bool tried_selected{false};
int counter = 256;
while (!new_selected || !tried_selected) { while (--counter > 0 && (!new_selected || !tried_selected)) {
const CAddress selected{addrman->Select(/*new_only=*/false, NET_I2P).first}; const CAddress selected{addrman->Select(/*new_only=*/false, NET_I2P).first};
BOOST_REQUIRE(selected == i2p_addr || selected == i2p_addr2); BOOST_REQUIRE(selected == i2p_addr || selected == i2p_addr2);
if (selected == i2p_addr) { if (selected == i2p_addr) {
@ -249,6 +250,9 @@ BOOST_AUTO_TEST_CASE(addrman_select_by_network)
new_selected = true; new_selected = true;
} }
} }
BOOST_CHECK(new_selected);
BOOST_CHECK(tried_selected);
} }
BOOST_AUTO_TEST_CASE(addrman_select_special) BOOST_AUTO_TEST_CASE(addrman_select_special)