highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-28 14:02:53 +02:00
Code Issues Packages Projects Releases Wiki Activity

qt, refactor: Drop superfluous type conversions

Browse Source
This commit is contained in:
Hennadii Stepanov
2023-10-23 15:06:29 +01:00
parent f4e96c29a6
commit d8298e7f06
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/qt/psbtoperationsdialog.cpp
View File

@@ -167,13 +167,13 @@ void PSBTOperationsDialog::saveTransaction() {
} }
void PSBTOperationsDialog::updateTransactionDisplay() { void PSBTOperationsDialog::updateTransactionDisplay() {
m_ui->transactionDescription->setText(QString::fromStdString(renderTransaction(m_transaction_data))); m_ui->transactionDescription->setText(renderTransaction(m_transaction_data));
showTransactionStatus(m_transaction_data); showTransactionStatus(m_transaction_data);
} }
std::string PSBTOperationsDialog::renderTransaction(const PartiallySignedTransaction &psbtx) QString PSBTOperationsDialog::renderTransaction(const PartiallySignedTransaction &psbtx)
{ {
QString tx_description = ""; QString tx_description;
CAmount totalAmount = 0; CAmount totalAmount = 0;
for (const CTxOut& out : psbtx.tx->vout) { for (const CTxOut& out : psbtx.tx->vout) {
CTxDestination address; CTxDestination address;
@@ -217,7 +217,7 @@ std::string PSBTOperationsDialog::renderTransaction(const PartiallySignedTransac
tx_description.append(tr("Transaction has %1 unsigned inputs.").arg(QString::number(num_unsigned))); tx_description.append(tr("Transaction has %1 unsigned inputs.").arg(QString::number(num_unsigned)));
} }
return tx_description.toStdString(); return tx_description;
} }
void PSBTOperationsDialog::showStatus(const QString &msg, StatusLevel level) { void PSBTOperationsDialog::showStatus(const QString &msg, StatusLevel level) {

3
src/qt/psbtoperationsdialog.h
View File

@@ -6,6 +6,7 @@
#define BITCOIN_QT_PSBTOPERATIONSDIALOG_H #define BITCOIN_QT_PSBTOPERATIONSDIALOG_H
#include <QDialog> #include <QDialog>
#include <QString>
#include <psbt.h> #include <psbt.h>
#include <qt/clientmodel.h> #include <qt/clientmodel.h>
@@ -46,7 +47,7 @@ private:
size_t couldSignInputs(const PartiallySignedTransaction &psbtx); size_t couldSignInputs(const PartiallySignedTransaction &psbtx);
void updateTransactionDisplay(); void updateTransactionDisplay();
std::string renderTransaction(const PartiallySignedTransaction &psbtx); QString renderTransaction(const PartiallySignedTransaction &psbtx);
void showStatus(const QString &msg, StatusLevel level); void showStatus(const QString &msg, StatusLevel level);
void showTransactionStatus(const PartiallySignedTransaction &psbtx); void showTransactionStatus(const PartiallySignedTransaction &psbtx);
}; };