highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-15 16:38:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

doc fixups for 33106

Browse Source
This commit is contained in:
glozow
2025-08-15 11:23:46 -04:00
parent c568511e8c
commit daa40a3ff9
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
doc/release-notes-33106.md
View File

@@ -9,8 +9,7 @@ changed to 100 satoshis per kvB. They can still be changed using their respectiv
recommended to change both together if you decide to do so. recommended to change both together if you decide to do so.
Other minimum feerates (e.g. the dust feerate, the minimum returned by the fee estimator, and all feerates used by the Other minimum feerates (e.g. the dust feerate, the minimum returned by the fee estimator, and all feerates used by the
wallet) remain unchanged. The mempool minimum feerate still changes in response to high volume but more gradually, as a wallet) remain unchanged. The mempool minimum feerate still changes in response to high volume.
result of the change to the incremental relay feerate.
Note that unless these lower defaults are widely adopted across the network, transactions created with lower fee rates Note that unless these lower defaults are widely adopted across the network, transactions created with lower fee rates
are not guaranteed to propagate or confirm. The wallet feerates remain unchanged; `-mintxfee` must be changed before are not guaranteed to propagate or confirm. The wallet feerates remain unchanged; `-mintxfee` must be changed before

3
src/test/miner_tests.cpp
View File

@@ -218,7 +218,8 @@ void MinerTestingSetup::TestPackageSelection(const CScript& scriptPubKey, const
tx.vout[0].nValue = 5000000000LL - 100000000; tx.vout[0].nValue = 5000000000LL - 100000000;
tx.vout[1].nValue = 100000000; // 1BTC output tx.vout[1].nValue = 100000000; // 1BTC output
// Increase size to avoid rounding errors: when the feerate is extremely small (i.e. 1sat/kvB), evaluating the fee // Increase size to avoid rounding errors: when the feerate is extremely small (i.e. 1sat/kvB), evaluating the fee
// at a smaller transaction size gives us a rounded value of 0. // at smaller sizes gives us rounded values that are equal to each other, which means we incorrectly include
// hashFreeTx2 + hashLowFeeTx2.
BulkTransaction(tx, 4000); BulkTransaction(tx, 4000);
Txid hashFreeTx2 = tx.GetHash(); Txid hashFreeTx2 = tx.GetHash();
AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx)); AddToMempool(tx_mempool, entry.Fee(0).SpendsCoinbase(true).FromTx(tx));

2
test/functional/feature_rbf.py
View File

@@ -583,7 +583,7 @@ class ReplaceByFeeTest(BitcoinTestFramework):
tx = self.wallet.send_self_transfer(from_node=self.nodes[0])['tx'] tx = self.wallet.send_self_transfer(from_node=self.nodes[0])['tx']
# Higher fee, higher feerate, different txid, but the replacement does not provide a relay # Higher fee, higher feerate, different txid, but the replacement does not provide a relay
# fee conforming to node's `incrementalrelayfee` policy of 1000 sat per KB. # fee conforming to node's `incrementalrelayfee` policy of 100 sat per KB.
assert_equal(self.nodes[0].getmempoolinfo()["incrementalrelayfee"], Decimal("0.000001")) assert_equal(self.nodes[0].getmempoolinfo()["incrementalrelayfee"], Decimal("0.000001"))
tx.vout[0].nValue -= 1 tx.vout[0].nValue -= 1
assert_raises_rpc_error(-26, "insufficient fee", self.nodes[0].sendrawtransaction, tx.serialize().hex()) assert_raises_rpc_error(-26, "insufficient fee", self.nodes[0].sendrawtransaction, tx.serialize().hex())