mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-15 16:33:52 +02:00
refactor: use PSBTFillOptions for filling and signing
Replace the sign, finalize , bip32derivs and sighash_type arguments which are passed to FillPSBT() and SignPSBTInput() with a PSBTFillOptions struct. This makes it easier to add additional options later without large code churn, such as avoid_script_path proposed in #32857. It also makes the use of default boolean options safer compared to positional arguments that can easily get mixed up.
This commit is contained in:
@@ -364,14 +364,12 @@ public:
|
||||
}
|
||||
return {};
|
||||
}
|
||||
std::optional<PSBTError> fillPSBT(std::optional<int> sighash_type,
|
||||
bool sign,
|
||||
bool bip32derivs,
|
||||
std::optional<PSBTError> fillPSBT(const common::PSBTFillOptions& options,
|
||||
size_t* n_signed,
|
||||
PartiallySignedTransaction& psbtx,
|
||||
bool& complete) override
|
||||
{
|
||||
return m_wallet->FillPSBT(psbtx, complete, sighash_type, sign, bip32derivs, n_signed);
|
||||
return m_wallet->FillPSBT(psbtx, options, complete, n_signed);
|
||||
}
|
||||
WalletBalances getBalances() override
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user