highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-08-28 05:56:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: fix anti-fee-sniping off-by-one error

Browse Source
This commit is contained in:
ishaanam
2025-08-01 15:31:36 -04:00
parent 75ed673193
commit e07e2532b4
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/functional/wallet_send.py
View File

@@ -15,6 +15,7 @@ from test_framework.util import (
assert_equal, assert_equal,
assert_fee_amount, assert_fee_amount,
assert_greater_than, assert_greater_than,
assert_greater_than_or_equal,
assert_raises_rpc_error, assert_raises_rpc_error,
count_bytes, count_bytes,
) )
@@ -149,7 +150,9 @@ class WalletSendTest(BitcoinTestFramework):
else: else:
if add_to_wallet: if add_to_wallet:
decoded_tx = from_wallet.gettransaction(txid=res["txid"], verbose=True)["decoded"] decoded_tx = from_wallet.gettransaction(txid=res["txid"], verbose=True)["decoded"]
assert_greater_than(decoded_tx["locktime"], from_wallet.getblockcount() - 100) # the locktime should be within 100 blocks of the
# block height
assert_greater_than_or_equal(decoded_tx["locktime"], from_wallet.getblockcount() - 100)
if expect_sign: if expect_sign:
assert_equal(res["complete"], True) assert_equal(res["complete"], True)

5
test/functional/wallet_sendall.py
View File

@@ -11,6 +11,7 @@ from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import ( from test_framework.util import (
assert_equal, assert_equal,
assert_greater_than, assert_greater_than,
assert_greater_than_or_equal,
assert_raises_rpc_error, assert_raises_rpc_error,
) )
@@ -437,7 +438,9 @@ class SendallTest(BitcoinTestFramework):
self.add_utxos([10,11]) self.add_utxos([10,11])
tx_from_wallet = self.test_sendall_success(sendall_args = [self.remainder_target]) tx_from_wallet = self.test_sendall_success(sendall_args = [self.remainder_target])
assert_greater_than(tx_from_wallet["decoded"]["locktime"], tx_from_wallet["blockheight"] - 100) # the locktime should be within 100 blocks of the
# block height
assert_greater_than_or_equal(tx_from_wallet["decoded"]["locktime"], tx_from_wallet["blockheight"] - 100)
self.log.info("Testing sendall does not do anti-fee-sniping when locktime is specified") self.log.info("Testing sendall does not do anti-fee-sniping when locktime is specified")
self.add_utxos([10,11]) self.add_utxos([10,11])