mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-04-27 23:39:46 +02:00
Merge bitcoin/bitcoin#31011: refactor: move util/pcp and util/netif to common/
fd38711217ci: make CI job fail when check-deps.sh script fails (Ryan Ofsky)d51edecddccommon: move pcp.cpp and netif.cpp files from util to common library since they depend on netaddress.cpp (Ryan Ofsky) Pull request description: Move util/pcp.cpp and util/netif.cpp to common/ because they depend on netaddress.cpp which is part of the common library. This was causing check-deps.sh script to fail as reported by _fanquake_ in https://github.com/bitcoin/bitcoin/pull/30415#issuecomment-2385475097. Also make CI fail when the `check-deps.sh` script fails. Previously it would output errors but not cause the job to fail (which was not intended). ACKs for top commit: Sjors: utACKfd38711217laanwj: Untested ACKfd38711217achow101: ACKfd38711217tdb3: ACKfd38711217Tree-SHA512: 06316e68617ded7d96d540c9934b08cf9fbba5ff5e7f54d7a0c0a9087a26bf8adc97e9e8c39a2bfd3da34e27f3652b1531ec6136a2c69393ae0b26585abadb6b
This commit is contained in:
@@ -194,7 +194,10 @@ cd "$BUILD_DIR/src"
|
||||
extract_symbols "$TEMP_DIR"
|
||||
if check_libraries "$TEMP_DIR"; then
|
||||
echo "Success! No unexpected dependencies were detected."
|
||||
RET=0
|
||||
else
|
||||
echo >&2 "Error: Unexpected dependencies were detected. Check previous output."
|
||||
RET=1
|
||||
fi
|
||||
rm -r "$TEMP_DIR"
|
||||
exit $RET
|
||||
|
||||
Reference in New Issue
Block a user