Delete error-prone CScript constructor

2025-11-12 15:09:59 +01:00 · 2019-05-31 10:01:15 -04:00
parent c7cfd20a77
commit e1a55690e6
3 changed files with 9 additions and 5 deletions
--- a/src/script/script.h
+++ b/src/script/script.h
@@ -437,7 +437,9 @@ public:

    explicit CScript(opcodetype b)     { operator<<(b); }
    explicit CScript(const CScriptNum& b) { operator<<(b); }
-    explicit CScript(const std::vector<unsigned char>& b) { operator<<(b); }
+    // delete non-existent constructor to defend against future introduction
+    // e.g. via prevector
+    explicit CScript(const std::vector<unsigned char>& b) = delete;


    CScript& operator<<(int64_t b) { return push_int64(b); }