highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-30 09:40:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make lifetime correctness easier to see (avoid reference lifetime extension)

Browse Source
This commit is contained in:
practicalswift 2020-02-26 20:04:23 +00:00
parent e7ddbd9893
commit e37f53648e
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/fuzz/bloom_filter.cpp
View File

@ -27,7 +27,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
while (fuzzed_data_provider.remaining_bytes() > 0) { while (fuzzed_data_provider.remaining_bytes() > 0) {
switch (fuzzed_data_provider.ConsumeIntegralInRange(0, 6)) { switch (fuzzed_data_provider.ConsumeIntegralInRange(0, 6)) {
case 0: { case 0: {
const std::vector<unsigned char>& b = ConsumeRandomLengthByteVector(fuzzed_data_provider); const std::vector<unsigned char> b = ConsumeRandomLengthByteVector(fuzzed_data_provider);
(void)bloom_filter.contains(b); (void)bloom_filter.contains(b);
bloom_filter.insert(b); bloom_filter.insert(b);
const bool present = bloom_filter.contains(b); const bool present = bloom_filter.contains(b);

2
src/test/fuzz/rolling_bloom_filter.cpp
View File

@ -24,7 +24,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
while (fuzzed_data_provider.remaining_bytes() > 0) { while (fuzzed_data_provider.remaining_bytes() > 0) {
switch (fuzzed_data_provider.ConsumeIntegralInRange(0, 2)) { switch (fuzzed_data_provider.ConsumeIntegralInRange(0, 2)) {
case 0: { case 0: {
const std::vector<unsigned char>& b = ConsumeRandomLengthByteVector(fuzzed_data_provider); const std::vector<unsigned char> b = ConsumeRandomLengthByteVector(fuzzed_data_provider);
(void)rolling_bloom_filter.contains(b); (void)rolling_bloom_filter.contains(b);
rolling_bloom_filter.insert(b); rolling_bloom_filter.insert(b);
const bool present = rolling_bloom_filter.contains(b); const bool present = rolling_bloom_filter.contains(b);

2
src/test/fuzz/util.h
View File

@ -27,7 +27,7 @@ NODISCARD inline std::vector<uint8_t> ConsumeRandomLengthByteVector(FuzzedDataPr
template <typename T> template <typename T>
NODISCARD inline Optional<T> ConsumeDeserializable(FuzzedDataProvider& fuzzed_data_provider, size_t max_length = 4096) noexcept NODISCARD inline Optional<T> ConsumeDeserializable(FuzzedDataProvider& fuzzed_data_provider, size_t max_length = 4096) noexcept
{ {
const std::vector<uint8_t>& buffer = ConsumeRandomLengthByteVector(fuzzed_data_provider, max_length); const std::vector<uint8_t> buffer = ConsumeRandomLengthByteVector(fuzzed_data_provider, max_length);
CDataStream ds{buffer, SER_NETWORK, INIT_PROTO_VERSION}; CDataStream ds{buffer, SER_NETWORK, INIT_PROTO_VERSION};
T obj; T obj;
try { try {