highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-14 07:23:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

qa: fee estimation with RBF test cleanups

Browse Source 
Followups to #22539

Co-Authored-By: Sebastian Falbesoner <sebastian.falbesoner@gmail.com>
This commit is contained in:
Antoine Poinsot
2021-10-15 12:29:27 +02:00
parent 15f5fd62af
commit e50213967b
1 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test/functional/feature_fee_estimation.py
View File

@ -131,16 +131,15 @@ def check_estimates(node, fees_seen):
def send_tx(node, utxo, feerate): def send_tx(node, utxo, feerate):
"""Broadcast a 1in-1out transaction with a specific input and feerate (sat/vb).""" """Broadcast a 1in-1out transaction with a specific input and feerate (sat/vb)."""
overhead, op, scriptsig, nseq, value, spk = 10, 36, 5, 4, 8, 24
tx_size = overhead + op + scriptsig + nseq + value + spk
fee = tx_size * feerate
tx = CTransaction() tx = CTransaction()
tx.vin = [CTxIn(COutPoint(int(utxo["txid"], 16), utxo["vout"]), REDEEM_SCRIPT)] tx.vin = [CTxIn(COutPoint(int(utxo["txid"], 16), utxo["vout"]), REDEEM_SCRIPT)]
tx.vout = [CTxOut(int(utxo["amount"] * COIN) - fee, P2SH)] tx.vout = [CTxOut(int(utxo["amount"] * COIN), P2SH)]
txid = node.sendrawtransaction(tx.serialize().hex())
return txid # vbytes == bytes as we are using legacy transactions
fee = tx.get_vsize() * feerate
tx.vout[0].nValue -= fee
return node.sendrawtransaction(tx.serialize().hex())
class EstimateFeeTest(BitcoinTestFramework): class EstimateFeeTest(BitcoinTestFramework):
@ -297,12 +296,9 @@ class EstimateFeeTest(BitcoinTestFramework):
miner.prioritisetransaction(txid=txid, fee_delta=-COIN) miner.prioritisetransaction(txid=txid, fee_delta=-COIN)
self.generate(miner, 1) self.generate(miner, 1)
# RBF the low-fee transactions # RBF the low-fee transactions
while True: while len(utxos_to_respend) > 0:
try: u = utxos_to_respend.pop(0)
u = utxos_to_respend.pop(0) send_tx(node, u, high_feerate)
send_tx(node, u, high_feerate)
except IndexError:
break
# Mine the last replacement txs # Mine the last replacement txs
self.sync_mempools(wait=0.1, nodes=[node, miner]) self.sync_mempools(wait=0.1, nodes=[node, miner])