highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 07:09:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor(headerssync): Process spans of headers

Browse Source 
More lightweight than vectors which needed to be copied in tests. Also good to get rid of headers_batch-vector before breaking up test.
This commit is contained in:
Hodlinator
2025-09-09 21:04:47 +02:00
parent a4ac9915a9
commit e984618d0b
3 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/headerssync.cpp
View File

@@ -1,4 +1,4 @@
// Copyright (c) 2022 The Bitcoin Core developers
// Copyright (c) 2022-present The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
@@ -66,8 +66,8 @@ void HeadersSyncState::Finalize()
/** Process the next batch of headers received from our peer.
* Validate and store commitments, and compare total chainwork to our target to
* see if we can switch to REDOWNLOAD mode. */
HeadersSyncState::ProcessingResult HeadersSyncState::ProcessNextHeaders(const
std::vector<CBlockHeader>& received_headers, const bool full_headers_message)
HeadersSyncState::ProcessingResult HeadersSyncState::ProcessNextHeaders(
std::span<const CBlockHeader> received_headers, const bool full_headers_message)
{
ProcessingResult ret;
@@ -137,7 +137,7 @@ HeadersSyncState::ProcessingResult HeadersSyncState::ProcessNextHeaders(const
return ret;
}
bool HeadersSyncState::ValidateAndStoreHeadersCommitments(const std::vector<CBlockHeader>& headers)
bool HeadersSyncState::ValidateAndStoreHeadersCommitments(std::span<const CBlockHeader> headers)
{
// The caller should not give us an empty set of headers.
Assume(headers.size() > 0);