highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-11 21:20:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#35605: wallet: rpc: Deprecate removeprunedfunds RPC

Browse Source 
f280f5eb47 wallet: rpc: deprecate removeprunedfunds (David Gumberg)
e5b7785447 test: wallet: resend: avoid internal behavior via removeprunedfunds (David Gumberg)

Pull request description:

  Originally added in https://github.com/bitcoin/bitcoin/pull/7558 as a companion to `importprunedfunds`, this RPC has no known helpful use while being both dangerous and a maintenance burden.

  Despite what the name says, it allows the deletion of arbitrary transactions, and `importprunedfunds` does not allow the importing of transactions not belonging to the user, and `listtransactions` does not list transactions not belonging to the wallet, so this RPC can only be used to delete transactions actually belonging to the wallet, and in the unlikely event that transactions not belonging to the wallet are present, they cause no harm except for occupying a few bytes on the users disk.

ACKs for top commit:
  achow101:
    ACK f280f5eb47
  polespinasa:
    ACK f280f5eb47
  pablomartin4btc:
    reACK f280f5eb47

Tree-SHA512: ed9c30c50be514d637999b4c8f3fa9b9b1446a5553e3974703638b45d8f55f1291f5cfb82dd2ead6d0743e424e9e3b1edbd56fc04dae3dcdee4d175e2a1ce061
This commit is contained in:
Ava Chow
2026-08-12 14:15:17 -07:00
parent 2f72123f61 f280f5eb47
commit e9ed5e83a3
5 changed files with 61 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
doc/release-notes-removeprunedfunds.md Normal file
View File

@@ -0,0 +1,6 @@
Updated RPCs
------------
- The `removeprunedfunds` RPC has been deprecated and will be removed in the
next major release. In order to continue using it, `bitcoind` must be started
with the `-deprecatedrpc=removeprunedfunds` option.