mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-31 08:13:52 +02:00
Merge bitcoin/bitcoin#29690: clang-tidy: Enable misc-no-recursion
78407b99ed[clang-tidy] Enable the misc-no-recursion check (dergoegge) Pull request description: Recursion is a frequent source of stack overflow bugs. Secondly, introduction of recursion can be non-obvious. This PR proposes to use the clang-tidy `misc-no-recursion` check to make introduction of new recursion obvious. We don't make use of recursion a lot in our code base but there are a few places that need suppressions anyway (mostly the descriptor and univalue/rpc code). ACKs for top commit: stickies-v: ACK78407b99edTheCharlatan: Re-ACK78407b99edfanquake: ACK78407b99edTree-SHA512: 34126d704c46086fe7371906ca852c25ced1dbd5fcfd85bf623810cd171a797569a92a33c7e26b8dc01c30c7bbf81aa326718926e8354585091411989a4edb14
This commit is contained in:
@@ -115,6 +115,8 @@ code.
|
||||
Use `reinterpret_cast` and `const_cast` as appropriate.
|
||||
- Prefer [`list initialization ({})`](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-list) where possible.
|
||||
For example `int x{0};` instead of `int x = 0;` or `int x(0);`
|
||||
- Recursion is checked by clang-tidy and thus must be made explicit. Use
|
||||
`NOLINTNEXTLINE(misc-no-recursion)` to suppress the check.
|
||||
|
||||
For function calls a namespace should be specified explicitly, unless such functions have been declared within it.
|
||||
Otherwise, [argument-dependent lookup](https://en.cppreference.com/w/cpp/language/adl), also known as ADL, could be
|
||||
|
||||
Reference in New Issue
Block a user