highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-12 23:18:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use adapter pattern for the network deserializer

Browse Source
This commit is contained in:
Jonas Schnelli
2019-06-13 11:25:54 +02:00
parent 1a5c656c31
commit efecb74677
2 changed files with 42 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
src/net.h
View File

@@ -637,20 +637,40 @@ public:
* transport protocol agnostic CNetMessage (command & payload)
*/
class TransportDeserializer {
public:
// prepare for next message
virtual void Reset() = 0;
// returns true if the current deserialization is complete
virtual bool Complete() const = 0;
// checks if the potential message in deserialization is oversized
virtual bool OversizedMessageDetected() const = 0;
// set the serialization context version
virtual void SetVersion(int version) = 0;
// read and deserialize data
virtual int Read(const char *data, unsigned int bytes) = 0;
// decomposes a message from the context
virtual CNetMessage GetMessage(const CMessageHeader::MessageStartChars& message_start, int64_t time) = 0;
virtual ~TransportDeserializer() {}
};
class V1TransportDeserializer : public TransportDeserializer
{
private:
mutable CHash256 hasher;
mutable uint256 data_hash;
public:
bool in_data; // parsing header (false) or data (true)
CDataStream hdrbuf; // partially received header
CMessageHeader hdr; // complete header
unsigned int nHdrPos;
CDataStream vRecv; // received message data
unsigned int nHdrPos;
unsigned int nDataPos;
TransportDeserializer(const CMessageHeader::MessageStartChars& pchMessageStartIn, int nTypeIn, int nVersionIn) : hdrbuf(nTypeIn, nVersionIn), hdr(pchMessageStartIn), vRecv(nTypeIn, nVersionIn) {
const uint256& GetMessageHash() const;
int readHeader(const char *pch, unsigned int nBytes);
int readData(const char *pch, unsigned int nBytes);
public:
V1TransportDeserializer(const CMessageHeader::MessageStartChars& pchMessageStartIn, int nTypeIn, int nVersionIn) : hdrbuf(nTypeIn, nVersionIn), hdr(pchMessageStartIn), vRecv(nTypeIn, nVersionIn) {
Reset();
}
@@ -664,25 +684,23 @@ public:
data_hash.SetNull();
hasher.Reset();
}
bool complete() const
bool Complete() const
{
if (!in_data)
return false;
return (hdr.nMessageSize == nDataPos);
}
const uint256& GetMessageHash() const;
void SetVersion(int nVersionIn)
{
hdrbuf.SetVersion(nVersionIn);
vRecv.SetVersion(nVersionIn);
}
int readHeader(const char *pch, unsigned int nBytes);
int readData(const char *pch, unsigned int nBytes);
bool OversizedMessageDetected() const {
return (in_data && hdr.nMessageSize > MAX_PROTOCOL_MESSAGE_LENGTH);
}
int Read(const char *pch, unsigned int nBytes) {
return in_data ? readData(pch, nBytes) : readHeader(pch, nBytes);
}
CNetMessage GetMessage(const CMessageHeader::MessageStartChars& message_start, int64_t time);
};