highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-06 11:13:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

coinselection: Tiebreak SRD eviction by weight

Browse Source 
When UTXOs tie in effective value, prefer keeping the lower weight UTXO.

Co-authored-by: Yancy <github@yancy.lol>
This commit is contained in:
Murch
2026-03-20 15:19:52 -07:00
parent 58dccd27e1
commit eff9e798b9
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/wallet/coinselection.cpp
View File

@@ -529,7 +529,7 @@ class MinOutputGroupComparator
public: public:
int operator() (const OutputGroup& group1, const OutputGroup& group2) const int operator() (const OutputGroup& group1, const OutputGroup& group2) const
{ {
return group1.GetSelectionAmount() > group2.GetSelectionAmount(); return descending_effval_weight(group1, group2);
} }
}; };

7
src/wallet/test/coinselection_tests.cpp
View File

@@ -283,6 +283,13 @@ BOOST_AUTO_TEST_CASE(srd_test)
AddDuplicateCoins(utxo_pool, /*count=*/3, /*amount=*/7 * CENT, cs_params); AddDuplicateCoins(utxo_pool, /*count=*/3, /*amount=*/7 * CENT, cs_params);
TestSRDSuccess("Select most valuable UTXOs for acceptable weight", utxo_pool, /*selection_target=*/20 * CENT, cs_params, /*max_selection_weight=*/4 * 4 * (P2WPKH_INPUT_VSIZE - 1 )); TestSRDSuccess("Select most valuable UTXOs for acceptable weight", utxo_pool, /*selection_target=*/20 * CENT, cs_params, /*max_selection_weight=*/4 * 4 * (P2WPKH_INPUT_VSIZE - 1 ));
TestSRDFail("No acceptable weight possible", utxo_pool, /*selection_target=*/25 * CENT, cs_params, /*max_selection_weight=*/4 * 3 * P2WPKH_INPUT_VSIZE, /*expect_max_weight_exceeded=*/true); TestSRDFail("No acceptable weight possible", utxo_pool, /*selection_target=*/25 * CENT, cs_params, /*max_selection_weight=*/4 * 3 * P2WPKH_INPUT_VSIZE, /*expect_max_weight_exceeded=*/true);
// Create UTXO pool with UTXOs of same effective value but different weights
std::vector<OutputGroup> mixed_weight_pool;
AddDuplicateCoins(mixed_weight_pool, /*count=*/100, /*amount=*/5 * CENT, cs_params);
mixed_weight_pool.push_back(MakeCoin(5 * CENT, true, cs_params, /*custom_spending_vsize=*/P2WPKH_INPUT_VSIZE - 1));
TestSRDSuccess("Tie-break same effective value with lower weight", utxo_pool, /*selection_target=*/9 * CENT, cs_params,
/*max_selection_weight=*/4 * 3 * (P2WPKH_INPUT_VSIZE - 1));
} }
} }