highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-08-02 23:53:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

[addrman] Remove unused test_before_evict argument from Good()

Browse Source 
This has never been used in the public interface method since it was
introduced in #9037.
This commit is contained in:
John Newbery
2021-07-20 13:59:12 +01:00
parent 201c5e4aec
commit f036dfbb69
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/addrman.h
View File

@@ -536,12 +536,12 @@ public:
} }
//! Mark an entry as accessible. //! Mark an entry as accessible.
void Good(const CService &addr, bool test_before_evict = true, int64_t nTime = GetAdjustedTime()) void Good(const CService &addr, int64_t nTime = GetAdjustedTime())
EXCLUSIVE_LOCKS_REQUIRED(!cs) EXCLUSIVE_LOCKS_REQUIRED(!cs)
{ {
LOCK(cs); LOCK(cs);
Check(); Check();
Good_(addr, test_before_evict, nTime); Good_(addr, /* test_before_evict */ true, nTime);
Check(); Check();
} }

2
src/test/addrman_tests.cpp
View File

@@ -76,7 +76,7 @@ public:
{ {
int64_t nLastSuccess = 1; int64_t nLastSuccess = 1;
// Set last good connection in the deep past. // Set last good connection in the deep past.
Good(addr, true, nLastSuccess); Good(addr, nLastSuccess);
bool count_failure = false; bool count_failure = false;
int64_t nLastTry = GetAdjustedTime()-61; int64_t nLastTry = GetAdjustedTime()-61;

2
src/test/fuzz/addrman.cpp
View File

@@ -80,7 +80,7 @@ FUZZ_TARGET_INIT(addrman, initialize_addrman)
[&] { [&] {
const std::optional<CService> opt_service = ConsumeDeserializable<CService>(fuzzed_data_provider); const std::optional<CService> opt_service = ConsumeDeserializable<CService>(fuzzed_data_provider);
if (opt_service) { if (opt_service) {
addr_man.Good(*opt_service, fuzzed_data_provider.ConsumeBool(), ConsumeTime(fuzzed_data_provider)); addr_man.Good(*opt_service, ConsumeTime(fuzzed_data_provider));
} }
}, },
[&] { [&] {