highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-16 11:53:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

[addrman] Ensure collisions eventually get resolved

Browse Source 
After 40 minutes, time out a test-before-evict entry and just evict without
testing. Otherwise, if we were unable to test an entry for some reason, we
might break using feelers altogether.
This commit is contained in:
Suhas Daftuar 2019-02-26 16:34:26 -05:00
parent 4991e3c813
commit f71fdda3bc
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/addrman.cpp
View File

@ -569,6 +569,13 @@ void CAddrMan::ResolveCollisions_()
Good_(info_new, false, GetAdjustedTime()); Good_(info_new, false, GetAdjustedTime());
erase_collision = true; erase_collision = true;
} }
} else if (GetAdjustedTime() - info_new.nLastSuccess > ADDRMAN_TEST_WINDOW) {
// If the collision hasn't resolved in some reasonable amount of time,
// just evict the old entry -- we must not be able to
// connect to it for some reason.
LogPrint(BCLog::ADDRMAN, "Unable to test; swapping %s for %s in tried table anyway\n", info_new.ToString(), info_old.ToString());
Good_(info_new, false, GetAdjustedTime());
erase_collision = true;
} }
} else { // Collision is not actually a collision anymore } else { // Collision is not actually a collision anymore
Good_(info_new, false, GetAdjustedTime()); Good_(info_new, false, GetAdjustedTime());

3
src/addrman.h
View File

@ -166,6 +166,9 @@ public:
//! the maximum number of tried addr collisions to store //! the maximum number of tried addr collisions to store
#define ADDRMAN_SET_TRIED_COLLISION_SIZE 10 #define ADDRMAN_SET_TRIED_COLLISION_SIZE 10
//! the maximum time we'll spend trying to resolve a tried table collision, in seconds
static const int64_t ADDRMAN_TEST_WINDOW = 40*60; // 40 minutes
/** /**
* Stochastical (IP) address manager * Stochastical (IP) address manager
*/ */