highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-18 07:50:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: Remove unused sanitizer suppressions

Browse Source 
* The GCC suppression was fixed in gcc-11, which is available on all LTS
  releases of Linux distros.
* The feerate suppression was likely fixed and does not trigger anymore.
  If it was to trigger again, the underlying bug should be fixed instead
  of suppressing it.
* The bench suppression does not trigger anymore.

Also, add comments to tsan suppressions on how to reproduce.
This commit is contained in:
MarcoFalke 2023-04-20 12:23:44 +02:00
parent 4c40837a45
commit fa15a9934e
No known key found for this signature in database
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/sanitizer_suppressions/tsan
View File

@ -13,6 +13,8 @@ race:zmq::*
race:bitcoin-qt race:bitcoin-qt
# deadlock (TODO fix) # deadlock (TODO fix)
# To reproduce, see:
# https://github.com/bitcoin/bitcoin/issues/19303#issuecomment-1514926359
deadlock:Chainstate::ConnectTip deadlock:Chainstate::ConnectTip
# Intentional deadlock in tests # Intentional deadlock in tests
@ -35,7 +37,7 @@ race:libzmq
# https://github.com/bitcoin/bitcoin/issues/20618 # https://github.com/bitcoin/bitcoin/issues/20618
race:CZMQAbstractPublishNotifier::SendZmqMessage race:CZMQAbstractPublishNotifier::SendZmqMessage
# https://github.com/bitcoin/bitcoin/pull/20218, https://github.com/bitcoin/bitcoin/pull/20745 # https://github.com/bitcoin/bitcoin/pull/27498#issuecomment-1517410478
race:epoll_ctl race:epoll_ctl
# https://github.com/bitcoin/bitcoin/issues/23366 # https://github.com/bitcoin/bitcoin/issues/23366

6
test/sanitizer_suppressions/ubsan
View File

@ -5,16 +5,12 @@
# names can be used. # names can be used.
# See https://github.com/google/sanitizers/issues/1364 # See https://github.com/google/sanitizers/issues/1364
# https://github.com/bitcoin/bitcoin/pull/21798#issuecomment-829180719
signed-integer-overflow:policy/feerate.cpp
# -fsanitize=integer suppressions # -fsanitize=integer suppressions
# =============================== # ===============================
# Dependencies # Dependencies
# ------------ # ------------
# Suppressions in dependencies that are developed outside this repository. # Suppressions in dependencies that are developed outside this repository.
unsigned-integer-overflow:*/include/c++/ unsigned-integer-overflow:*/include/c++/
unsigned-integer-overflow:bench/bench.h
# unsigned-integer-overflow in FuzzedDataProvider's ConsumeIntegralInRange # unsigned-integer-overflow in FuzzedDataProvider's ConsumeIntegralInRange
unsigned-integer-overflow:FuzzedDataProvider.h unsigned-integer-overflow:FuzzedDataProvider.h
unsigned-integer-overflow:leveldb/ unsigned-integer-overflow:leveldb/
@ -31,8 +27,6 @@ implicit-signed-integer-truncation:leveldb/
implicit-unsigned-integer-truncation:*/include/c++/ implicit-unsigned-integer-truncation:*/include/c++/
implicit-unsigned-integer-truncation:leveldb/ implicit-unsigned-integer-truncation:leveldb/
implicit-unsigned-integer-truncation:test/fuzz/crypto_diff_fuzz_chacha20.cpp implicit-unsigned-integer-truncation:test/fuzz/crypto_diff_fuzz_chacha20.cpp
# std::variant warning fixed in https://github.com/gcc-mirror/gcc/commit/074436cf8cdd2a9ce75cadd36deb8301f00e55b9
implicit-unsigned-integer-truncation:std::__detail::__variant::_Variant_storage
shift-base:*/include/c++/ shift-base:*/include/c++/
shift-base:leveldb/ shift-base:leveldb/
shift-base:minisketch/ shift-base:minisketch/