Refactor: Turn the internal addrman check helper into a forced check

This commit is contained in:
MarcoFalke
2021-08-18 09:17:06 +02:00
parent fae5c633dc
commit fa298971e6
2 changed files with 10 additions and 9 deletions

View File

@@ -747,21 +747,21 @@ void CAddrMan::Check() const
{
AssertLockHeld(cs);
const int err = Check_();
// Run consistency checks 1 in m_consistency_check_ratio times if enabled
if (m_consistency_check_ratio == 0) return;
if (insecure_rand.randrange(m_consistency_check_ratio) >= 1) return;
const int err{ForceCheckAddrman()};
if (err) {
LogPrintf("ADDRMAN CONSISTENCY CHECK FAILED!!! err=%i\n", err);
assert(false);
}
}
int CAddrMan::Check_() const
int CAddrMan::ForceCheckAddrman() const
{
AssertLockHeld(cs);
// Run consistency checks 1 in m_consistency_check_ratio times if enabled
if (m_consistency_check_ratio == 0) return 0;
if (insecure_rand.randrange(m_consistency_check_ratio) >= 1) return 0;
LogPrint(BCLog::ADDRMAN, "Addrman checks started: new %i, tried %i, total %u\n", nNew, nTried, vRandom.size());
std::unordered_set<int> setTried;