highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-08-28 16:43:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

rpc: Properly use underlying type in GetAllOutputTypes

Browse Source 
Don't blindly assume it is int.

In practice this is usually `unsigned` or `int`, so this commit should
not change behavior.
This commit is contained in:
MarcoFalke
2020-05-30 10:13:48 -04:00
parent fa41c65702
commit fa58469c77
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/rpc/rawtransaction.cpp
View File

@@ -512,7 +512,8 @@ static UniValue decoderawtransaction(const JSONRPCRequest& request)
static std::string GetAllOutputTypes() static std::string GetAllOutputTypes()
{ {
std::vector<std::string> ret; std::vector<std::string> ret;
for (int i = TX_NONSTANDARD; i <= TX_WITNESS_UNKNOWN; ++i) { using U = std::underlying_type<txnouttype>::type;
for (U i = (U)TX_NONSTANDARD; i <= (U)TX_WITNESS_UNKNOWN; ++i) {
ret.emplace_back(GetTxnOutputType(static_cast<txnouttype>(i))); ret.emplace_back(GetTxnOutputType(static_cast<txnouttype>(i)));
} }
return Join(ret, ", "); return Join(ret, ", ");