mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-30 07:43:48 +02:00
test: Allow to set height in create_block
Previously, it was only possible to set the height indirectly by calling create_coinbase outside the create_block function. This is fine, but verbose and not needed. Just like hashprev can be set directly (instead of using the value from tmpl), allow height to be set directly. Also, use it in one place. The other places are done in a scripted-diff. Also, add a unit test for the new feature.
This commit is contained in:
@@ -15,7 +15,6 @@ from test_framework.address import (
|
||||
from test_framework.blocktools import (
|
||||
add_witness_commitment,
|
||||
create_block,
|
||||
create_coinbase,
|
||||
)
|
||||
from test_framework.test_framework import BitcoinTestFramework
|
||||
from test_framework.messages import (
|
||||
@@ -419,7 +418,7 @@ class ZMQTest (BitcoinTestFramework):
|
||||
bump_txid = self.nodes[0].sendrawtransaction(orig_tx['tx'].serialize().hex())
|
||||
# Mine the pre-bump tx
|
||||
txs_to_add = [orig_tx['hex']] + [tx['hex'] for tx in more_tx]
|
||||
block = create_block(int(self.nodes[0].getbestblockhash(), 16), create_coinbase(self.nodes[0].getblockcount()+1), txlist=txs_to_add)
|
||||
block = create_block(int(self.nodes[0].getbestblockhash(), 16), height=self.nodes[0].getblockcount() + 1, txlist=txs_to_add)
|
||||
add_witness_commitment(block)
|
||||
block.solve()
|
||||
assert_equal(self.nodes[0].submitblock(block.serialize().hex()), None)
|
||||
|
||||
Reference in New Issue
Block a user