highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-30 02:31:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: Make requires_wallet private

Browse Source 
The bool is only used to call a public helper, which some tests already
do. So use the public helper in all tests consistently and make the
confusingly named bool private.
This commit is contained in:
MacroFake
2022-11-10 10:12:39 +01:00
parent 9dce30194b
commit fa68937b89
5 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/functional/rpc_rawtransaction.py
View File

@ -65,8 +65,6 @@ class RawTransactionsTest(BitcoinTestFramework):
# whitelist all peers to speed up tx relay / mempool sync
for args in self.extra_args:
args.append("-whitelist=noban@127.0.0.1")
self.requires_wallet = self.is_specified_wallet_compiled()
self.supports_cli = False
def setup_network(self):
@ -85,7 +83,8 @@ class RawTransactionsTest(BitcoinTestFramework):
self.sendrawtransaction_testmempoolaccept_tests()
self.decoderawtransaction_tests()
self.transaction_version_number_tests()
if self.requires_wallet and not self.options.descriptors:
if self.is_specified_wallet_compiled() and not self.options.descriptors:
self.import_deterministic_coinbase_privkeys()
self.raw_multisig_transaction_legacy_tests()
def getrawtransaction_tests(self):