util: Make util/error bilingual_str (refactor)

Translated strings should not end up in the debug log, stderr, or
returned by an RPC.

Changing the util methods in util/error to return a bilingual_str paves
the way to achieve this goal in the long term.
This commit is contained in:
MarcoFalke
2019-08-20 11:00:43 -04:00
parent 119e97ae2d
commit fa70d199d0
4 changed files with 20 additions and 18 deletions

View File

@@ -41,12 +41,12 @@ std::string ResolveErrMsg(const std::string& optname, const std::string& strBind
return strprintf(_("Cannot resolve -%s address: '%s'").translated, optname, strBind);
}
std::string AmountHighWarn(const std::string& optname)
bilingual_str AmountHighWarn(const std::string& optname)
{
return strprintf(_("%s is set very high!").translated, optname);
return strprintf(_("%s is set very high!"), optname);
}
std::string AmountErrMsg(const std::string& optname, const std::string& strValue)
bilingual_str AmountErrMsg(const std::string& optname, const std::string& strValue)
{
return strprintf(_("Invalid amount for -%s=<amount>: '%s'").translated, optname, strValue);
return strprintf(_("Invalid amount for -%s=<amount>: '%s'"), optname, strValue);
}