test: Use lowercase env var as attribute name

This is a refactor.
This commit is contained in:
MarcoFalke
2025-06-07 10:09:30 +02:00
parent fac49094cd
commit fa91835ec6

View File

@ -285,19 +285,19 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass):
paths = types.SimpleNamespace() paths = types.SimpleNamespace()
binaries = { binaries = {
"bitcoind": ("bitcoind", "BITCOIND"), "bitcoind": "BITCOIND",
"bitcoin-cli": ("bitcoincli", "BITCOINCLI"), "bitcoin-cli": "BITCOINCLI",
"bitcoin-util": ("bitcoinutil", "BITCOINUTIL"), "bitcoin-util": "BITCOINUTIL",
"bitcoin-chainstate": ("bitcoinchainstate", "BITCOINCHAINSTATE"), "bitcoin-chainstate": "BITCOINCHAINSTATE",
"bitcoin-wallet": ("bitcoinwallet", "BITCOINWALLET"), "bitcoin-wallet": "BITCOINWALLET",
} }
for binary, [attribute_name, env_variable_name] in binaries.items(): for binary, env_variable_name in binaries.items():
default_filename = os.path.join( default_filename = os.path.join(
self.config["environment"]["BUILDDIR"], self.config["environment"]["BUILDDIR"],
"bin", "bin",
binary + self.config["environment"]["EXEEXT"], binary + self.config["environment"]["EXEEXT"],
) )
setattr(paths, attribute_name, os.getenv(env_variable_name, default=default_filename)) setattr(paths, env_variable_name.lower(), os.getenv(env_variable_name, default=default_filename))
# BITCOIN_CMD environment variable can be specified to invoke bitcoin # BITCOIN_CMD environment variable can be specified to invoke bitcoin
# wrapper binary instead of other executables. # wrapper binary instead of other executables.
paths.bitcoin_cmd = shlex.split(os.getenv("BITCOIN_CMD", "")) or None paths.bitcoin_cmd = shlex.split(os.getenv("BITCOIN_CMD", "")) or None