highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-12 15:22:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

qa: Use files for stdout/stderr to support Windows

Browse Source
This commit is contained in:
MarcoFalke
2018-08-03 17:23:33 -04:00
parent facb56ffaf
commit faabd7bc47
2 changed files with 36 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/functional/test_framework/test_node.py
View File

@ -122,7 +122,7 @@ class TestNode():
assert self.rpc_connected and self.rpc is not None, self._node_msg("Error: no RPC connection")
return getattr(self.rpc, name)
def start(self, extra_args=None, stdout=None, stderr=None, *args, **kwargs):
def start(self, extra_args=None, *, stdout=None, stderr=None, **kwargs):
"""Start the node."""
if extra_args is None:
extra_args = self.extra_args
@ -143,7 +143,7 @@ class TestNode():
# add environment variable LIBC_FATAL_STDERR_=1 so that libc errors are written to stderr and not the terminal
subp_env = dict(os.environ, LIBC_FATAL_STDERR_="1")
self.process = subprocess.Popen(self.args + extra_args, env=subp_env, stdout=stdout, stderr=stderr, *args, **kwargs)
self.process = subprocess.Popen(self.args + extra_args, env=subp_env, stdout=stdout, stderr=stderr, **kwargs)
self.running = True
self.log.debug("bitcoind started, waiting for RPC to come up")