highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-09 09:51:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

doc: Clarify and move "hygienic commit" note

Browse Source 
The prior version mentions to update the tests *first*, which is wrong.
It must be updated at the same time in the same commit.
This commit is contained in:
MarcoFalke
2025-05-20 18:42:29 +02:00
parent fac8b05197
commit fab79c1a25
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CONTRIBUTING.md
View File

@ -115,6 +115,7 @@ fixes or code moves with actual code changes.
Make sure each individual commit is hygienic: that it builds successfully on its Make sure each individual commit is hygienic: that it builds successfully on its
own without warnings, errors, regressions, or test failures. own without warnings, errors, regressions, or test failures.
This means tests must be updated in the same commit that changes the behavior.
Commit messages should be verbose by default consisting of a short subject line Commit messages should be verbose by default consisting of a short subject line
(50 chars max), a blank line and detailed explanatory text as separate (50 chars max), a blank line and detailed explanatory text as separate

3
doc/developer-notes.md
View File

@ -805,9 +805,6 @@ General Bitcoin Core
on the master branch. Otherwise, all new pull requests will start failing the tests, resulting in on the master branch. Otherwise, all new pull requests will start failing the tests, resulting in
confusion and mayhem. confusion and mayhem.
- *Explanation*: If the test suite is to be updated for a change, this has to
be done first.
Logging Logging
------- -------